[
https://issues.apache.org/jira/browse/ARTEMIS-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388741#comment-16388741
]
ASF GitHub Bot commented on ARTEMIS-1653:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1822#discussion_r172699944
--- Diff:
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
---
@@ -109,7 +109,7 @@ public void stop() throws SQLException {
protected abstract void createSchema() throws SQLException;
protected final void createTable(String... schemaSqls) throws
SQLException {
- createTableIfNotExists(connection, sqlProvider.getTableName(),
schemaSqls);
+ createTableIfNotExists(sqlProvider.getTableName(), schemaSqls);
--- End diff --
easier to ask than reading the code :)
Why removing this parameter here?
(sorry if I'm lazy.. I have a bunch of other PRs to check.. so it was
easier to ask).
> Allow database tables to be created externally
> ----------------------------------------------
>
> Key: ARTEMIS-1653
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1653
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Niels Lippke
> Priority: Major
>
> In some environments (e.g. production) it is not allowed that applications
> create their own schema. It's common practice to pass DDL-Statetements to
> DBAs instead prior to rollout.
> Currently the broker does not support this scenario. If the required tables
> already exist the broker fails to start.
> A better approach is that if the broker detects empy tables and initializes
> them in the very same way it does if the tables dont't exist.
> See also discussion in
> [forum|http://activemq.2283324.n4.nabble.com/ARTEMIS-Server-doesn-t-start-if-JDBC-store-is-used-and-table-NODE-MANAGER-STORE-is-empty-td4735779.html].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
