[ 
https://issues.apache.org/jira/browse/ARTEMIS-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423630#comment-16423630
 ] 

ASF GitHub Bot commented on ARTEMIS-1653:
-----------------------------------------

GitHub user franz1981 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1986

    ARTEMIS-1653 Allow database tables to be created externally

    The previous commit about this feature wasn't using the right ResultSet
    to count the rows in a table.
    Additional checks have been added to:
    - verify that the first SQL statement is a CREATE TABLE
    - log if the existing rows are less than the expected ones

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-1653

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1986.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1986
    
----
commit 66c442dd6a4eae02f7ac0d84eb0bffd6df9a01b3
Author: Francesco Nigro <nigro.fra@...>
Date:   2018-04-03T08:11:04Z

    ARTEMIS-1653 Allow database tables to be created externally
    
    The previous commit about this feature wasn't using the right ResultSet
    to count the rows in a table.
    Additional checks have been added to:
    - verify that the first SQL statement is a CREATE TABLE
    - log if the existing rows are less than the expected ones

----


> Allow database tables to be created externally
> ----------------------------------------------
>
>                 Key: ARTEMIS-1653
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1653
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Niels Lippke
>            Assignee: Francesco Nigro
>            Priority: Major
>
> In some environments (e.g. production) it is not allowed that applications 
> create their own schema. It's common practice to pass DDL-Statetements to 
> DBAs instead prior to rollout.
> Currently the broker does not support this scenario. If the required tables 
> already exist the broker fails to start.
> A better approach is that if the broker detects empy tables and initializes 
> them in the very same way it does if the tables dont't exist.
> See also discussion in 
> [forum|http://activemq.2283324.n4.nabble.com/ARTEMIS-Server-doesn-t-start-if-JDBC-store-is-used-and-table-NODE-MANAGER-STORE-is-empty-td4735779.html].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to