ASF GitHub Bot commented on ARTEMIS-1653:

Github user nlippke commented on a diff in the pull request:

    --- Diff: 
    @@ -109,7 +109,7 @@ public void stop() throws SQLException {
        protected abstract void createSchema() throws SQLException;
        protected final void createTable(String... schemaSqls) throws 
SQLException {
    -      createTableIfNotExists(connection, sqlProvider.getTableName(), 
    +      createTableIfNotExists(sqlProvider.getTableName(), schemaSqls);
    --- End diff --
    `createTableIfNotExists` was `private static` before. I needed to change it 
to non-static in order for `TestJDBCDriver` to be able to access the underlying 
connection to create the empty table for the test.

> Allow database tables to be created externally
> ----------------------------------------------
>                 Key: ARTEMIS-1653
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1653
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Niels Lippke
>            Priority: Major
> In some environments (e.g. production) it is not allowed that applications 
> create their own schema. It's common practice to pass DDL-Statetements to 
> DBAs instead prior to rollout.
> Currently the broker does not support this scenario. If the required tables 
> already exist the broker fails to start.
> A better approach is that if the broker detects empy tables and initializes 
> them in the very same way it does if the tables dont't exist.
> See also discussion in 
> [forum|http://activemq.2283324.n4.nabble.com/ARTEMIS-Server-doesn-t-start-if-JDBC-store-is-used-and-table-NODE-MANAGER-STORE-is-empty-td4735779.html].

This message was sent by Atlassian JIRA

Reply via email to