[
https://issues.apache.org/jira/browse/AMQ-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474094#comment-16474094
]
ASF GitHub Bot commented on AMQ-6959:
-------------------------------------
GitHub user SaivR1t opened a pull request:
https://github.com/apache/activemq/pull/282
AMQ-6959
We should not create a Throwable object (which will call fillInStackTrace()
method) in case of non TRACE logging. For example if we have an INFO log level,
message will no be created and logged, but a Throwable object will be created.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SaivR1t/activemq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq/pull/282.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #282
----
commit 2a953481821fcbfefbdd235a2c5b7f7e7ef8a6b7
Author: saivr1t <alexansavon@...>
Date: 2018-05-14T12:11:10Z
AMQ-6959
Avoid creating a Throwable in case of non-trace logging
----
> Avoid creating a Throwable in case of non-trace logging
> -------------------------------------------------------
>
> Key: AMQ-6959
> URL: https://issues.apache.org/jira/browse/AMQ-6959
> Project: ActiveMQ
> Issue Type: Improvement
> Reporter: Alexander Savonin
> Priority: Minor
> Fix For: 5.16.0
>
>
> We should not create a Throwable object (which will call fillInStackTrace()
> method) in case of non TRACE logging. For example if we have an INFO log
> level, message will not be created and logged, but a Throwable object will be
> created.
> I'm talking about the following method:
> org.apache.activemq.transaction.Synchronization#afterRollback
> {code:java}
> LOG.trace("rollback {}", ack, new Throwable("here")); {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
