[ https://issues.apache.org/jira/browse/AMQ-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474155#comment-16474155 ]
ASF GitHub Bot commented on AMQ-6959: ------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/activemq/pull/282 > Avoid creating a Throwable in case of non-trace logging > ------------------------------------------------------- > > Key: AMQ-6959 > URL: https://issues.apache.org/jira/browse/AMQ-6959 > Project: ActiveMQ > Issue Type: Improvement > Reporter: Alexander Savonin > Assignee: Christopher L. Shannon > Priority: Minor > Fix For: 5.16.0 > > > We should not create a Throwable object (which will call fillInStackTrace() > method) in case of non TRACE logging. For example if we have an INFO log > level, message will not be created and logged, but a Throwable object will be > created. > I'm talking about the following method: > org.apache.activemq.transaction.Synchronization#afterRollback > {code:java} > LOG.trace("rollback {}", ack, new Throwable("here")); {code} > PR: https://github.com/apache/activemq/pull/282 -- This message was sent by Atlassian JIRA (v7.6.3#76005)