[
https://issues.apache.org/jira/browse/AMQ-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474159#comment-16474159
]
ASF subversion and git services commented on AMQ-6959:
------------------------------------------------------
Commit 20f6c0a035fba7f9633487c0588bccee070ccf77 in activemq's branch
refs/heads/activemq-5.15.x from saivr1t
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=20f6c0a ]
AMQ-6959
Avoid creating a Throwable in case of non-trace logging
(cherry picked from commit 2a953481821fcbfefbdd235a2c5b7f7e7ef8a6b7)
> Avoid creating a Throwable in case of non-trace logging
> -------------------------------------------------------
>
> Key: AMQ-6959
> URL: https://issues.apache.org/jira/browse/AMQ-6959
> Project: ActiveMQ
> Issue Type: Improvement
> Reporter: Alexander Savonin
> Assignee: Christopher L. Shannon
> Priority: Minor
> Fix For: 5.16.0, 5.15.4
>
>
> We should not create a Throwable object (which will call fillInStackTrace()
> method) in case of non TRACE logging. For example if we have an INFO log
> level, message will not be created and logged, but a Throwable object will be
> created.
> I'm talking about the following method:
> org.apache.activemq.transaction.Synchronization#afterRollback
> {code:java}
> LOG.trace("rollback {}", ack, new Throwable("here")); {code}
> PR: https://github.com/apache/activemq/pull/282
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
