[
https://issues.apache.org/jira/browse/ARTEMIS-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506507#comment-16506507
]
ASF GitHub Bot commented on ARTEMIS-1918:
-----------------------------------------
GitHub user jostbg opened a pull request:
https://github.com/apache/activemq-artemis/pull/2130
ARTEMIS-1918 Remove unused private field clientID
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jostbg/activemq-artemis ARTEMIS-1918
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2130
----
commit 61fa8f636774f32051b0182266005b0f7f3b50cb
Author: Johan Stenberg <35264802+jostbg@...>
Date: 2018-06-08T19:57:24Z
ARTEMIS-1918 Remove unused private field clientID
----
> RemotingConnectionImpl contains unused private clientID field used by
> toString()
> --------------------------------------------------------------------------------
>
> Key: ARTEMIS-1918
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1918
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.6.1
> Reporter: Johan Stenberg
> Priority: Minor
>
> The
> [RemotingConnectionImpl|https://github.com/apache/activemq-artemis/blob/master/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java#L79]
> declares a private field clientID that is never set but used by the
> toString() method. The base class
> [AbstractRemotingConnection|https://github.com/apache/activemq-artemis/blob/master/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/AbstractRemotingConnection.java#L47]
> already declares a private field clientId with appropriate setters. Setting
> the cliendID value via this setter on the RemotingConnectionImpl is not
> reflected by it's string representation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
