[
https://issues.apache.org/jira/browse/ARTEMIS-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516303#comment-16516303
]
ASF GitHub Bot commented on ARTEMIS-1918:
-----------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2130
> RemotingConnectionImpl contains unused private clientID field used by
> toString()
> --------------------------------------------------------------------------------
>
> Key: ARTEMIS-1918
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1918
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.6.1
> Reporter: Johan Stenberg
> Priority: Minor
>
> The
> [RemotingConnectionImpl|https://github.com/apache/activemq-artemis/blob/master/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java#L79]
> declares a private field clientID that is never set but used by the
> toString() method. The base class
> [AbstractRemotingConnection|https://github.com/apache/activemq-artemis/blob/master/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/AbstractRemotingConnection.java#L47]
> already declares a private field clientId with appropriate setters. Setting
> the cliendID value via this setter on the RemotingConnectionImpl is not
> reflected by it's string representation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
