[ 
https://issues.apache.org/jira/browse/ARTEMIS-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581103#comment-16581103
 ] 

ASF subversion and git services commented on ARTEMIS-1918:
----------------------------------------------------------

Commit b00eaad20ff2d6d68d242efc09624284d363b38e in activemq-artemis's branch 
refs/heads/2.6.x from [~johan1]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b00eaad ]

ARTEMIS-1918 Remove unused private field clientID
(cherry picked from commit 197661cb5800973a721789e1f828bebf4c8999bc)


> RemotingConnectionImpl contains unused private clientID field used by 
> toString()
> --------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1918
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1918
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>          Components: Broker
>    Affects Versions: 2.6.1
>            Reporter: Johan Stenberg
>            Priority: Minor
>             Fix For: 2.7.0
>
>
> The 
> [RemotingConnectionImpl|https://github.com/apache/activemq-artemis/blob/master/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/RemotingConnectionImpl.java#L79]
>  declares a private field clientID that is never set but used by the 
> toString() method. The base class 
> [AbstractRemotingConnection|https://github.com/apache/activemq-artemis/blob/master/artemis-core-client/src/main/java/org/apache/activemq/artemis/spi/core/protocol/AbstractRemotingConnection.java#L47]
>  already declares a private field clientId with appropriate setters. Setting 
> the cliendID value via this setter on the RemotingConnectionImpl is not 
> reflected by it's string representation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to