[
https://issues.apache.org/jira/browse/ARTEMIS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577352#comment-16577352
]
ASF GitHub Bot commented on ARTEMIS-2023:
-----------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2238#discussion_r209438668
--- Diff:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java
---
@@ -885,7 +891,7 @@ public TemporaryQueue createTemporaryQueue() throws
JMSException {
}
try {
- ActiveMQTemporaryQueue queue =
ActiveMQDestination.createTemporaryQueue(this);
+ ActiveMQTemporaryQueue queue =
ActiveMQDestination.createTemporaryQueue(this, (enable1xPrefixes ?
PacketImpl.OLD_TEMP_QUEUE_PREFIX.toString() : ""));
--- End diff --
nit: but can avoid a string concatenation that occurs in the new
createTemporaryQueue method for users not enabling, if the if was moved
around, and the existing method called for that.
final ActiveMQTemporaryQueue queue;
if (enable1xPrefixes) {
queue = ActiveMQDestination.createTemporaryQueue(this,
PacketImpl.OLD_TEMP_QUEUE_PREFIX.toString());
} else {
queue = ActiveMQDestination.createTemporaryQueue(this);
}
> Support 1x prefixes for JMS destinations instantiated using session
> -------------------------------------------------------------------
>
> Key: ARTEMIS-2023
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2023
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
