[ 
https://issues.apache.org/jira/browse/ARTEMIS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578320#comment-16578320
 ] 

ASF GitHub Bot commented on ARTEMIS-2023:
-----------------------------------------

Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2238#discussion_r209621351
  
    --- Diff: 
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
 ---
    @@ -623,6 +636,8 @@ public void decode(final ActiveMQBuffer buffer) {
           deserializationBlackList = 
BufferHelper.readNullableSimpleStringAsString(buffer);
     
           deserializationWhiteList = 
BufferHelper.readNullableSimpleStringAsString(buffer);
    +
    +      enable1xPrefixes = buffer.readBoolean();
    --- End diff --
    
    yes.. but didn't you add a boolean? that would from my quick glance break 
serialization with older versions.. wouldn't it?


> Support 1x prefixes for JMS destinations instantiated using session
> -------------------------------------------------------------------
>
>                 Key: ARTEMIS-2023
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2023
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to