[
https://issues.apache.org/jira/browse/ARTEMIS-2023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579998#comment-16579998
]
ASF GitHub Bot commented on ARTEMIS-2023:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2249#discussion_r210009695
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/client/StoreConfigTest.java
---
@@ -289,6 +294,107 @@ public void testCreateQueue() throws Exception {
jmsServer.stop();
}
+ @Test
+ public void testCompatibilityWith260() {
+ List<String> transportConfigurations = new ArrayList<>();
+ transportConfigurations.add("tst");
+ ConnectionFactoryConfigurationImpl configuration =
(ConnectionFactoryConfigurationImpl) new ConnectionFactoryConfigurationImpl();
+
configuration.setName("np").setConnectorNames(transportConfigurations);
+
+ ByteBuffer buffer =
ByteBuffer.allocate(configuration.getEncodeSize());
+ ActiveMQBuffer activeMQBuffer = new
ChannelBufferWrapper(Unpooled.wrappedBuffer(buffer));
+ activeMQBuffer.clear();
+ encodeVersion260(activeMQBuffer, configuration);
+ configuration.decode(activeMQBuffer);
+ }
+
+ public void encodeVersion260(final ActiveMQBuffer buffer, final
ConnectionFactoryConfigurationImpl connectionFactoryConfiguration) {
--- End diff --
I think you should use the compatibility tests for this instead. disagree
with the test itself here.
> Support 1x prefixes for JMS destinations instantiated using session
> -------------------------------------------------------------------
>
> Key: ARTEMIS-2023
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2023
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Fix For: 2.7.0, 2.6.3
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
