[
https://issues.apache.org/jira/browse/ARTEMIS-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588516#comment-16588516
]
ASF GitHub Bot commented on ARTEMIS-2044:
-----------------------------------------
GitHub user calohmn opened a pull request:
https://github.com/apache/activemq-artemis/pull/2258
ARTEMIS-2044 Add onSendError, onMessageRouteError to broker plugin
This fixes
[ARTEMIS-2044](https://issues.apache.org/jira/browse/ARTEMIS-2044).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bsinno/activemq-artemis
PR/brokerplugin_new_errorhandling_methods
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2258.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2258
----
commit 60fea84d0a61ef254fbe5a8de192406a865ee3e3
Author: Carsten Lohmann <carsten.lohmann@...>
Date: 2018-08-22T08:06:30Z
ARTEMIS-2044 Add onSendError, onMessageRouteError to
ActiveMQServerMessagePlugin
----
> Add broker plugin methods to handle errors during "send"/"route" operations
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-2044
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2044
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Carsten Lohmann
> Priority: Major
>
> In the {{ActiveMQServerMessagePlugin}} class, there are the "beforeSend" and
> "afterSend" methods for getting notified about the sending of a message.
> There is no method for being notified on when there was an error sending the
> message, though. This would be something like an "onSendError" method.
> Same applies to "beforeMessageRoute"/"afterMessageRoute".
> (An "onDeliverError" method wouldn't fit here since "afterDeliver" is being
> called in a "finally" block, hence also in case of an exception).
>
> So it would be good to have methods like "onSendError" and
> "onMessageRouteError" in {{ActiveMQServerMessagePlugin}}.
> This is needed for implementing OpenTracing support via a broker plugin - see
> ARTEMIS-2028.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
