[
https://issues.apache.org/jira/browse/ARTEMIS-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588540#comment-16588540
]
ASF GitHub Bot commented on ARTEMIS-2044:
-----------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2258#discussion_r211867898
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/plugin/ActiveMQServerMessagePlugin.java
---
@@ -65,6 +65,21 @@ default void afterSend(ServerSession session,
Transaction tx, Message message, b
this.afterSend(tx, message, direct, noAutoCreateQueue, result);
}
+ /**
+ * When there was an exception sending the message
+ *
+ * @param session
+ * @param tx
+ * @param message
+ * @param direct
+ * @param noAutoCreateQueue
+ * @param e the exception that occurred when sending the message
+ * @throws ActiveMQException
+ */
+ default void onSendError(ServerSession session, Transaction tx, Message
message, boolean direct, boolean noAutoCreateQueue,
--- End diff --
Nit: onSendException
> Add broker plugin methods to handle errors during "send"/"route" operations
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-2044
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2044
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Carsten Lohmann
> Priority: Major
>
> In the {{ActiveMQServerMessagePlugin}} class, there are the "beforeSend" and
> "afterSend" methods for getting notified about the sending of a message.
> There is no method for being notified on when there was an error sending the
> message, though. This would be something like an "onSendError" method.
> Same applies to "beforeMessageRoute"/"afterMessageRoute".
> (An "onDeliverError" method wouldn't fit here since "afterDeliver" is being
> called in a "finally" block, hence also in case of an exception).
>
> So it would be good to have methods like "onSendError" and
> "onMessageRouteError" in {{ActiveMQServerMessagePlugin}}.
> This is needed for implementing OpenTracing support via a broker plugin - see
> ARTEMIS-2028.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
