[
https://issues.apache.org/jira/browse/ARTEMIS-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588798#comment-16588798
]
ASF GitHub Bot commented on ARTEMIS-2044:
-----------------------------------------
Github user calohmn commented on the issue:
https://github.com/apache/activemq-artemis/pull/2258
@cshannon Do you mean the changes in `PostOfficeImpl` and
`ServerSessionImpl`?
The added whitespace there is because of a new try-catch block in each
class, adding indentation to the lines moved into that block.
And it's all added spaces there, no tabs. IDE is also configured to use
spaces (setting coming from the imported artemis-codestyle).
> Add broker plugin methods to handle errors during "send"/"route" operations
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-2044
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2044
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Carsten Lohmann
> Priority: Major
>
> In the {{ActiveMQServerMessagePlugin}} class, there are the "beforeSend" and
> "afterSend" methods for getting notified about the sending of a message.
> There is no method for being notified on when there was an error sending the
> message, though. This would be something like an "onSendError" method.
> Same applies to "beforeMessageRoute"/"afterMessageRoute".
> (An "onDeliverError" method wouldn't fit here since "afterDeliver" is being
> called in a "finally" block, hence also in case of an exception).
>
> So it would be good to have methods like "onSendError" and
> "onMessageRouteError" in {{ActiveMQServerMessagePlugin}}.
> This is needed for implementing OpenTracing support via a broker plugin - see
> ARTEMIS-2028.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
