[
https://issues.apache.org/jira/browse/ARTEMIS-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633728#comment-16633728
]
ASF GitHub Bot commented on ARTEMIS-2101:
-----------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2338#discussion_r221534313
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
---
@@ -350,6 +352,8 @@ private String appendIgnoresToFilter(String
filterString) {
filterString += "!" + storeAndForwardPrefix;
filterString += ",!" + managementAddress;
filterString += ",!" + managementNotificationAddress;
+ //advisory topics shouldn't be clustered
+ filterString += ",!" + ADVISORY_TOPIC_PREFIX;
--- End diff --
This is Openwire specific, should avoid pushing protocol specifics into
core.
What happens it another protocol needs an address not clustered?
Would be better to design this in an agnostic way, eg a flag on the address
or queue, to not cluster bridge, which the protocol managers can set on creating
> Do not cluster OpenWire advisory topics
> ---------------------------------------
>
> Key: ARTEMIS-2101
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2101
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker, OpenWire
> Affects Versions: 2.6.3
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Fix For: 2.7.0, 2.6.4
>
>
> ClusterConnectionBridge isn't correctly filtering out messages relates to
> advisory topics
> that would be sent across clusters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
