[ 
https://issues.apache.org/jira/browse/ARTEMIS-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633735#comment-16633735
 ] 

ASF GitHub Bot commented on ARTEMIS-2101:
-----------------------------------------

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2338#discussion_r221536659
  
    --- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
 ---
    @@ -350,6 +352,8 @@ private String appendIgnoresToFilter(String 
filterString) {
           filterString += "!" + storeAndForwardPrefix;
           filterString += ",!" + managementAddress;
           filterString += ",!" + managementNotificationAddress;
    +      //advisory topics shouldn't be clustered
    +      filterString += ",!" + ADVISORY_TOPIC_PREFIX;
    --- End diff --
    
    The best wat I could think is to inject it as a constructor parameter 
similar to managementNotificationAddress; but advisory topics are just an 
OpenWire specific feature anyway


> Do not cluster OpenWire advisory topics
> ---------------------------------------
>
>                 Key: ARTEMIS-2101
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2101
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker, OpenWire
>    Affects Versions: 2.6.3
>            Reporter: Francesco Nigro
>            Assignee: Francesco Nigro
>            Priority: Major
>             Fix For: 2.7.0, 2.6.4
>
>
> ClusterConnectionBridge isn't correctly filtering out messages relates to 
> advisory topics
> that would be sent across clusters.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to