[
https://issues.apache.org/jira/browse/ARTEMIS-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635624#comment-16635624
]
ASF GitHub Bot commented on ARTEMIS-2101:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2338#discussion_r221985696
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java
---
@@ -154,6 +154,11 @@ public
OpenWireProtocolManager(OpenWireProtocolManagerFactory factory, ActiveMQS
if (cc != null) {
cc.addClusterTopologyListener(this);
}
+ if (supportAdvisory) {
--- End diff --
I wouldn't make it dependent on supportAdvisory.
Say you have two acceptors.. different IPs.. you will have this called
twice.
I would always add the filter, and check if the filter is not part of the
expression before you called it.
> Do not cluster OpenWire advisory topics
> ---------------------------------------
>
> Key: ARTEMIS-2101
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2101
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker, OpenWire
> Affects Versions: 2.6.3
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Fix For: 2.7.0, 2.6.4
>
>
> ClusterConnectionBridge isn't correctly filtering out messages relates to
> advisory topics
> that would be sent across clusters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
