[
https://issues.apache.org/jira/browse/ARTEMIS-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724506#comment-16724506
]
ASF GitHub Bot commented on ARTEMIS-2205:
-----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2467#discussion_r242725348
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/ActiveMQProtonRemotingConnection.java
---
@@ -119,10 +119,15 @@ public boolean isDestroyed() {
@Override
public void disconnect(boolean criticalError) {
- ErrorCondition errorCondition = new ErrorCondition();
- errorCondition.setCondition(AmqpSupport.CONNECTION_FORCED);
- amqpConnection.close(errorCondition);
- getTransportConnection().close();
+ amqpConnection.runLater(() -> {
+ ErrorCondition errorCondition = new ErrorCondition();
+ errorCondition.setCondition(AmqpSupport.CONNECTION_FORCED);
+ amqpConnection.close(errorCondition);
+ amqpConnection.flush();
+ });
+ amqpConnection.runLater(() -> {
--- End diff --
@franz1981 During my work, the first one was runNow, the second Later. (I
would accept better names BTW)
later I changed the first to later and forgot the other one :)
fixing it on my next ammend
> Make AMQP Processing Single Threaded and other AMQP perf improvements
> ---------------------------------------------------------------------
>
> Key: ARTEMIS-2205
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2205
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.6.3
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.7.0
>
>
> This is using Netty Executor (NIOLoop) to process AMQP.
> Instead of using a lock to enter the AMQP processing, what has issues on
> scaling up multiple connections per queue, it's using a single threaded
> executor.
>
>
> This represents a major improvement in AMQP. I will take my time to write a
> blog post about this with multiple scenarios comparing 2.6.3, master (before
> this change) and after. (I will post a link here to this JIRA).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
