[
https://issues.apache.org/jira/browse/ARTEMIS-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724679#comment-16724679
]
ASF GitHub Bot commented on ARTEMIS-2205:
-----------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2467#discussion_r242787574
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
---
@@ -471,40 +494,42 @@ public void onFlow(Link link) throws Exception {
@Override
public void onRemoteClose(Link link) throws Exception {
- lock();
- try {
+ handler.requireHandler();
+
+ // We scheduled it for later, as that will work through anything
that's pending on the current deliveries.
+ runLater(() -> {
link.close();
link.free();
- } finally {
- unlock();
- }
- ProtonDeliveryHandler linkContext = (ProtonDeliveryHandler)
link.getContext();
- if (linkContext != null) {
- linkContext.close(true);
- }
+ ProtonDeliveryHandler linkContext = (ProtonDeliveryHandler)
link.getContext();
+ if (linkContext != null) {
+ try {
+ linkContext.close(true);
+ } catch (Exception e) {
+ log.error(e.getMessage(), e);
--- End diff --
this should have a static logger method
> Make AMQP Processing Single Threaded and other AMQP perf improvements
> ---------------------------------------------------------------------
>
> Key: ARTEMIS-2205
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2205
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.6.3
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.7.0
>
>
> This is using Netty Executor (NIOLoop) to process AMQP.
> Instead of using a lock to enter the AMQP processing, what has issues on
> scaling up multiple connections per queue, it's using a single threaded
> executor.
>
>
> This represents a major improvement in AMQP. I will take my time to write a
> blog post about this with multiple scenarios comparing 2.6.3, master (before
> this change) and after. (I will post a link here to this JIRA).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
