[
https://issues.apache.org/jira/browse/ARTEMIS-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724684#comment-16724684
]
ASF GitHub Bot commented on ARTEMIS-2205:
-----------------------------------------
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2467#discussion_r242788099
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerSenderContext.java
---
@@ -469,20 +530,17 @@ public void close(ErrorCondition condition) throws
ActiveMQAMQPException {
sender.setCondition(condition);
}
protonSession.removeSender(sender);
- connection.lock();
- try {
- sender.close();
- } finally {
- connection.unlock();
- }
- connection.flush();
- try {
- sessionSPI.closeSender(brokerConsumer);
- } catch (Exception e) {
- log.warn(e.getMessage(), e);
- throw new ActiveMQAMQPInternalErrorException(e.getMessage());
- }
+ connection.runLater(() -> {
+ sender.close();
+ try {
+ sessionSPI.closeSender(brokerConsumer);
+ } catch (Exception e) {
+ log.warn(e.getMessage(), e);
--- End diff --
Static logger method needed
> Make AMQP Processing Single Threaded and other AMQP perf improvements
> ---------------------------------------------------------------------
>
> Key: ARTEMIS-2205
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2205
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.6.3
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.7.0
>
>
> This is using Netty Executor (NIOLoop) to process AMQP.
> Instead of using a lock to enter the AMQP processing, what has issues on
> scaling up multiple connections per queue, it's using a single threaded
> executor.
>
>
> This represents a major improvement in AMQP. I will take my time to write a
> blog post about this with multiple scenarios comparing 2.6.3, master (before
> this change) and after. (I will post a link here to this JIRA).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
