[
https://issues.apache.org/jira/browse/ARTEMIS-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732992#comment-16732992
]
ASF GitHub Bot commented on ARTEMIS-196:
----------------------------------------
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244987340
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
---
@@ -233,6 +239,11 @@ public Object createSender(ProtonServerSenderContext
protonSender,
return consumer;
}
+ private int getPriority(Map<Symbol, Object> properties) {
+ Integer value = properties == null ? null : (Integer)
properties.get(PRIORITY);
--- End diff --
I would use a cast to `Number` and call `Number::byteValue`
> Implementing Consumer Priority
> ------------------------------
>
> Key: ARTEMIS-196
> URL: https://issues.apache.org/jira/browse/ARTEMIS-196
> Project: ActiveMQ Artemis
> Issue Type: Sub-task
> Components: OpenWire
> Affects Versions: 1.0.0
> Reporter: Howard Gao
> Priority: Major
> Fix For: unscheduled
>
>
> ref: http://activemq.apache.org/consumer-priority.html
> org.apache.activemq.QueueConsumerPriorityTest
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
