[
https://issues.apache.org/jira/browse/ARTEMIS-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732984#comment-16732984
]
ASF GitHub Bot commented on ARTEMIS-196:
----------------------------------------
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244986539
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
---
@@ -95,6 +109,7 @@ public void encodeRest(final ActiveMQBuffer buffer) {
buffer.writeNullableSimpleString(filterString);
buffer.writeBoolean(browseOnly);
buffer.writeBoolean(requiresResponse);
+ buffer.writeInt(priority);
--- End diff --
I will write it as a byte, if we don't plan to support more then 127
priorities, consumer-side: but as I've said is a negligible save of space on
the wire
> Implementing Consumer Priority
> ------------------------------
>
> Key: ARTEMIS-196
> URL: https://issues.apache.org/jira/browse/ARTEMIS-196
> Project: ActiveMQ Artemis
> Issue Type: Sub-task
> Components: OpenWire
> Affects Versions: 1.0.0
> Reporter: Howard Gao
> Priority: Major
> Fix For: unscheduled
>
>
> ref: http://activemq.apache.org/consumer-priority.html
> org.apache.activemq.QueueConsumerPriorityTest
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
