[ 
https://issues.apache.org/jira/browse/ARTEMIS-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732982#comment-16732982
 ] 

ASF GitHub Bot commented on ARTEMIS-196:
----------------------------------------

Github user franz1981 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/2488#discussion_r244986350
  
    --- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
 ---
    @@ -25,20 +26,24 @@
     
        private SimpleString filterString;
     
    +   private int priority;
    --- End diff --
    
    I will change it as `byte` if we are not planning to support priorities > 
127 ie `Byte::MAX_VALUE`
    For small messages it *could* save some space (TBH to be verified with JOL 
tool)


> Implementing Consumer Priority
> ------------------------------
>
>                 Key: ARTEMIS-196
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-196
>             Project: ActiveMQ Artemis
>          Issue Type: Sub-task
>          Components: OpenWire
>    Affects Versions: 1.0.0
>            Reporter: Howard Gao
>            Priority: Major
>             Fix For: unscheduled
>
>
> ref: http://activemq.apache.org/consumer-priority.html
> org.apache.activemq.QueueConsumerPriorityTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to