[
https://issues.apache.org/jira/browse/ARTEMIS-2311?focusedWorklogId=229389&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229389
]
ASF GitHub Bot logged work on ARTEMIS-2311:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/19 21:20
Start Date: 17/Apr/19 21:20
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2627:
ARTEMIS-2311 Dealing with Protocol conversions and JMSReplyTo
URL: https://github.com/apache/activemq-artemis/pull/2627#discussion_r276438281
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
##########
@@ -196,7 +200,21 @@ private OpenWireMessageConverter() {
final ActiveMQDestination replyTo = messageSend.getReplyTo();
if (replyTo != null) {
- putMsgReplyTo(replyTo, marshaller, coreMessage);
+ if (replyTo instanceof TemporaryQueue) {
+ MessageUtil.setJMSReplyTo(coreMessage,
org.apache.activemq.artemis.jms.client.ActiveMQDestination.TEMP_QUEUE_QUALIFED_PREFIX
+ (((TemporaryQueue) replyTo).getQueueName()));
Review comment:
and for doing it for OpenWire, we could levy its implementation, and like
wise for AMQP can use qpid-jms varient, as they also need to handle foreign
message. As such this could form the basis of the converters. And if any
issues, well then there is issue in that handling in the producers, to which
would need fixing anyhow, but least we aren't recoding and maintaining two sets
of conversion logics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 229389)
Time Spent: 8h 40m (was: 8.5h)
> JMSReplyTo insconsistent when dealing with Protocol conversions
> ---------------------------------------------------------------
>
> Key: ARTEMIS-2311
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2311
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP, Broker, OpenWire
> Affects Versions: 2.7.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.8.0
>
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
