[
https://issues.apache.org/jira/browse/ARTEMIS-2311?focusedWorklogId=229381&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229381
]
ASF GitHub Bot logged work on ARTEMIS-2311:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/19 21:15
Start Date: 17/Apr/19 21:15
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2627:
ARTEMIS-2311 Dealing with Protocol conversions and JMSReplyTo
URL: https://github.com/apache/activemq-artemis/pull/2627#discussion_r276436235
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
##########
@@ -196,7 +200,21 @@ private OpenWireMessageConverter() {
final ActiveMQDestination replyTo = messageSend.getReplyTo();
if (replyTo != null) {
- putMsgReplyTo(replyTo, marshaller, coreMessage);
+ if (replyTo instanceof TemporaryQueue) {
+ MessageUtil.setJMSReplyTo(coreMessage,
org.apache.activemq.artemis.jms.client.ActiveMQDestination.TEMP_QUEUE_QUALIFED_PREFIX
+ (((TemporaryQueue) replyTo).getQueueName()));
Review comment:
you resolved it, just unresolved it. Its more about transform, we have to
have in the JMS client logic in producer.send Transform logic that handles a
foreign JMS Message, where we transform it to activemq version. As such this
really is very similar we are doing JMS transforms really....seems a bit of
duplication
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 229381)
Time Spent: 7h 50m (was: 7h 40m)
> JMSReplyTo insconsistent when dealing with Protocol conversions
> ---------------------------------------------------------------
>
> Key: ARTEMIS-2311
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2311
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP, Broker, OpenWire
> Affects Versions: 2.7.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.8.0
>
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
