[ 
https://issues.apache.org/jira/browse/ARTEMIS-2311?focusedWorklogId=229376&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-229376
 ]

ASF GitHub Bot logged work on ARTEMIS-2311:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Apr/19 21:11
            Start Date: 17/Apr/19 21:11
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on pull request #2627: 
ARTEMIS-2311 Dealing with Protocol conversions and JMSReplyTo
URL: https://github.com/apache/activemq-artemis/pull/2627#discussion_r276435575
 
 

 ##########
 File path: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
 ##########
 @@ -196,7 +200,21 @@ private OpenWireMessageConverter() {
 
       final ActiveMQDestination replyTo = messageSend.getReplyTo();
       if (replyTo != null) {
-         putMsgReplyTo(replyTo, marshaller, coreMessage);
+         if (replyTo instanceof TemporaryQueue) {
+            MessageUtil.setJMSReplyTo(coreMessage, 
org.apache.activemq.artemis.jms.client.ActiveMQDestination.TEMP_QUEUE_QUALIFED_PREFIX
 + (((TemporaryQueue) replyTo).getQueueName()));
 
 Review comment:
   What Query you referring to? This is about conversions.. I'm not sure how 
the TCK applies here.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 229376)
    Time Spent: 7h  (was: 6h 50m)

> JMSReplyTo insconsistent when dealing with Protocol conversions
> ---------------------------------------------------------------
>
>                 Key: ARTEMIS-2311
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2311
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: AMQP, Broker, OpenWire
>    Affects Versions: 2.7.0
>            Reporter: clebert suconic
>            Assignee: clebert suconic
>            Priority: Major
>             Fix For: 2.8.0
>
>          Time Spent: 7h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to