[
https://issues.apache.org/jira/browse/ARTEMIS-2320?focusedWorklogId=234544&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234544
]
ASF GitHub Bot logged work on ARTEMIS-2320:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/19 14:45
Start Date: 29/Apr/19 14:45
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on issue #2651:
ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning
URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487608496
So then i suggest leave the warning, warnings are there to suggest reviewing
and refactoring code, its not just about finding the sticky plaster to make the
warning go away. But to really review the code, and refactor it properly.
Its like code coverage, if you have a class that has low coverage, the
solution isn't just to add tests quickly for all your getters and setters,
which would get coverage up, but really you should add better coverage to real
code.
The point being, don't hide an issue with a sticky plaster, go fix it
properly, or leave the warning there, so it keeps getting noticed....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 234544)
Time Spent: 5h 40m (was: 5.5h)
> Upgrade errorprone compiler dependency to 2.3.3 and review the new warnings
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-2320
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2320
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.7.0
> Reporter: Jiri Daněk
> Priority: Minor
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
