[
https://issues.apache.org/jira/browse/ARTEMIS-2320?focusedWorklogId=240319&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240319
]
ASF GitHub Bot logged work on ARTEMIS-2320:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/19 16:30
Start Date: 10/May/19 16:30
Worklog Time Spent: 10m
Work Description: jdanekrh commented on pull request #2651: ARTEMIS-2320
Fix ClassCanBeStatic errorprone warning
URL: https://github.com/apache/activemq-artemis/pull/2651#discussion_r279750310
##########
File path:
artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/v12/StompFrameHandlerV12.java
##########
@@ -91,7 +91,7 @@ public StompFrame onAck(StompFrame request) {
return response;
}
- protected class StompDecoderV12 extends StompDecoderV11 {
+ protected static class StompDecoderV12 extends StompDecoderV11 {
Review comment:
make top-level class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 240319)
> Upgrade errorprone compiler dependency to 2.3.3 and review the new warnings
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-2320
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2320
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.7.0
> Reporter: Jiri Daněk
> Priority: Minor
> Fix For: 2.8.0
>
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
