[
https://issues.apache.org/jira/browse/ARTEMIS-2320?focusedWorklogId=234790&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234790
]
ASF GitHub Bot logged work on ARTEMIS-2320:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/19 18:24
Start Date: 29/Apr/19 18:24
Worklog Time Spent: 10m
Work Description: jdanekrh commented on issue #2651: ARTEMIS-2320 Fix
ClassCanBeStatic errorprone warning
URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487690177
The purpose of the warning isn't really to point out style issues about
class hierarchy, but a potential (tiny) performance issue, which is fixed by
just adding `static` everywhere.
> A non-static inner class has a reference to its outer class, and access to
the outer class' fields and methods. That class reference makes the inner class
larger and could cause the outer class instance to live in memory longer than
necessary. https://rules.sonarsource.com/java/tag/performance/RSPEC-2694
Another thing, does anybody ever read those warnings? They don't show in
IntelliJ (they don't show for me) and they get lost in mvn output...
I don't consider this PR very important, and it was easy to produce
(IntelliJ autofix), so I don't mind closing it and wait for the eventual
comprehensive refactoring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 234790)
Time Spent: 6.5h (was: 6h 20m)
> Upgrade errorprone compiler dependency to 2.3.3 and review the new warnings
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-2320
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2320
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.7.0
> Reporter: Jiri Daněk
> Priority: Minor
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
