[
https://issues.apache.org/jira/browse/ARTEMIS-2372?focusedWorklogId=254635&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254635
]
ASF GitHub Bot logged work on ARTEMIS-2372:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/19 20:49
Start Date: 05/Jun/19 20:49
Worklog Time Spent: 10m
Work Description: tabish121 commented on pull request #2695: ARTEMIS-2372
Filtering on Message Annotations
URL: https://github.com/apache/activemq-artemis/pull/2695#discussion_r290927683
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpExpiredMessageTest.java
##########
@@ -108,9 +109,16 @@ public void testExpiryThroughTTL() throws Exception {
connection = addConnection(client.connect());
session = connection.createSession();
- AmqpReceiver receiverDLQ =
session.createReceiver(getDeadLetterAddress());
+ AmqpReceiver receiverDLQ =
session.createReceiver(getDeadLetterAddress(), "_AMQ_ORIG_ADDRESS='" +
getQueueName() + "'");
Review comment:
Instead of disturbing an existing test to validate new functionality you
should really be writing new tests that cover the feature in depth with both
positive and negative validation tests to ensure that future changes don't
break and that the feature works as intended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 254635)
Time Spent: 20m (was: 10m)
> Support Filtering on Message Annotations
> ----------------------------------------
>
> Key: ARTEMIS-2372
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2372
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.9.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
