[
https://issues.apache.org/jira/browse/ARTEMIS-2372?focusedWorklogId=254659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254659
]
ASF GitHub Bot logged work on ARTEMIS-2372:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/19 21:16
Start Date: 05/Jun/19 21:16
Worklog Time Spent: 10m
Work Description: tabish121 commented on pull request #2695: ARTEMIS-2372
Filtering on Message Annotations
URL: https://github.com/apache/activemq-artemis/pull/2695#discussion_r290938313
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
##########
@@ -1263,7 +1263,10 @@ public Long getLongProperty(String key) throws
ActiveMQPropertyConversionExcepti
@Override
public Object getObjectProperty(String key) {
- if (key.equals(MessageUtil.TYPE_HEADER_NAME.toString())) {
+
+ if
(key.startsWith(AMQPMessageSupport.JMS_AMQP_MESSAGE_ANNOTATION_PREFIX)) {
Review comment:
You are putting illegal message annotations into the message from what I can
tell, and the test seems to validate that. The message that is received has
annotations which are of the form ({_AMQ_ORIG_QUEUE=testExpiryThroughTTL,
_AMQ_ORIG_ADDRESS=testExpiryThroughTTL, _AMQ_ORIG_MESSAGE_ID=69,
_AMQ_ACTUAL_EXPIRY=1559769271365}) which is illegal according the spec section
I posted and a receiver is technically required to close the connection if it
sees them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 254659)
Time Spent: 1h 10m (was: 1h)
> Support Filtering on Message Annotations
> ----------------------------------------
>
> Key: ARTEMIS-2372
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2372
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.9.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.10.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
