[
https://issues.apache.org/jira/browse/ARTEMIS-2372?focusedWorklogId=254723&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254723
]
ASF GitHub Bot logged work on ARTEMIS-2372:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/19 22:31
Start Date: 05/Jun/19 22:31
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2695:
ARTEMIS-2372 Filtering on Message Annotations
URL: https://github.com/apache/activemq-artemis/pull/2695#discussion_r290960985
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
##########
@@ -1263,7 +1263,10 @@ public Long getLongProperty(String key) throws
ActiveMQPropertyConversionExcepti
@Override
public Object getObjectProperty(String key) {
- if (key.equals(MessageUtil.TYPE_HEADER_NAME.toString())) {
+
+ if
(key.startsWith(AMQPMessageSupport.JMS_AMQP_MESSAGE_ANNOTATION_PREFIX)) {
Review comment:
@tabish121 when moving to DLQ or Expiry, the message is copied..
we could (perhaps should) instead of using annotations here (I agree it's
wrong), use a regular property.
After all when moving the message to DLQ or Expiry we are moving a copy of
the message, and not the original message. (you could see it that way..
although that's one line of argument)
Or perhaps we could fix it properly, and use proper annotations. but that
will break compatibility with previous AMQ5, as the message is always converted
from OpenWire into AMQP. (AMQ5 never preserves the AMQP message on that sense)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 254723)
Time Spent: 1h 40m (was: 1.5h)
> Support Filtering on Message Annotations
> ----------------------------------------
>
> Key: ARTEMIS-2372
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2372
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.9.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Priority: Major
> Fix For: 2.10.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
