[ 
https://issues.apache.org/jira/browse/ARTEMIS-2372?focusedWorklogId=255083&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-255083
 ]

ASF GitHub Bot logged work on ARTEMIS-2372:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Jun/19 13:15
            Start Date: 06/Jun/19 13:15
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on pull request #2695: 
ARTEMIS-2372 Filtering on Message Annotations
URL: https://github.com/apache/activemq-artemis/pull/2695#discussion_r291176728
 
 

 ##########
 File path: 
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
 ##########
 @@ -1263,7 +1263,10 @@ public Long getLongProperty(String key) throws 
ActiveMQPropertyConversionExcepti
 
    @Override
    public Object getObjectProperty(String key) {
-      if (key.equals(MessageUtil.TYPE_HEADER_NAME.toString())) {
+
+      if 
(key.startsWith(AMQPMessageSupport.JMS_AMQP_MESSAGE_ANNOTATION_PREFIX)) {
 
 Review comment:
   Ok, i will use extraProperties and do something about that...
   
   Just so you know this PR was about exposing the properties.. the use of 
messageAnnotations for this wasn't introduced here.
   
   
   But i will fix it as part of this PR.
   
   
   i will close it for now as I won't have time to finish it before 1 week. I 
may reopen it later.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 255083)
    Time Spent: 2.5h  (was: 2h 20m)

> Support Filtering on Message Annotations
> ----------------------------------------
>
>                 Key: ARTEMIS-2372
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2372
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.9.0
>            Reporter: clebert suconic
>            Assignee: clebert suconic
>            Priority: Major
>             Fix For: 2.10.0
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to