[ https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=295242&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295242 ]
ASF GitHub Bot logged work on ARTEMIS-2450: ------------------------------------------- Author: ASF GitHub Bot Created on: 15/Aug/19 06:33 Start Date: 15/Aug/19 06:33 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #2791: ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r314188891 ########## File path: artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationParserTest.java ########## @@ -257,6 +257,26 @@ public void testParsingDefaultServerConfigWithENCMaskedPwd() throws Exception { assertEquals("helloworld", bconfig.getPassword()); } + @Test + public void testParsingOverflowPageSize() throws Exception { + FileConfigurationParser parser = new FileConfigurationParser(); Review comment: This test, test the new change, but doesnt test for what we are protecting from. E.g whats the underlying issue being fixed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 295242) Time Spent: 0.5h (was: 20m) > page-size-bytes should not be greater than Integer.MAX_VALUE > ------------------------------------------------------------ > > Key: ARTEMIS-2450 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2450 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker > Reporter: yangwei > Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)