[ 
https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=296542&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296542
 ]

ASF GitHub Bot logged work on ARTEMIS-2450:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Aug/19 20:23
            Start Date: 16/Aug/19 20:23
    Worklog Time Spent: 10m 
      Work Description: michaelandrepearce commented on pull request #2791: 
ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r314877174
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java
 ##########
 @@ -505,6 +505,9 @@ public long getPageSizeBytes() {
    }
 
    public AddressSettings setPageSizeBytes(final long pageSize) {
+      if (pageSize > Integer.MAX_VALUE) {
+         throw new IllegalArgumentException("pageSize must be < " + 
Integer.MAX_VALUE);
 
 Review comment:
   Not really. If you now decode something thats larger than int it will blow 
up with the exception youve added. No different. Except we are actually making 
the method take the correct primitive number
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 296542)
    Time Spent: 1h 20m  (was: 1h 10m)

> page-size-bytes should not be greater than Integer.MAX_VALUE
> ------------------------------------------------------------
>
>                 Key: ARTEMIS-2450
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2450
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>            Reporter: yangwei
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to