[
https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=295919&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295919
]
ASF GitHub Bot logged work on ARTEMIS-2450:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Aug/19 01:16
Start Date: 16/Aug/19 01:16
Worklog Time Spent: 10m
Work Description: wy96f commented on pull request #2791: ARTEMIS-2450
page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r314554334
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java
##########
@@ -505,6 +505,9 @@ public long getPageSizeBytes() {
}
public AddressSettings setPageSizeBytes(final long pageSize) {
+ if (pageSize > Integer.MAX_VALUE) {
+ throw new IllegalArgumentException("pageSize must be < " +
Integer.MAX_VALUE);
Review comment:
The AddressSettings maybe persisted in disk, and if we change long to int,
we would incorrectly decode it. Does it make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 295919)
Time Spent: 50m (was: 40m)
> page-size-bytes should not be greater than Integer.MAX_VALUE
> ------------------------------------------------------------
>
> Key: ARTEMIS-2450
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2450
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: yangwei
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
