[
https://issues.apache.org/jira/browse/ARTEMIS-2442?focusedWorklogId=295246&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295246
]
ASF GitHub Bot logged work on ARTEMIS-2442:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Aug/19 06:38
Start Date: 15/Aug/19 06:38
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2785:
ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is
reached
URL: https://github.com/apache/activemq-artemis/pull/2785#discussion_r314189923
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQResourceLimitException.java
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.api.core;
+
+public final class ActiveMQResourceLimitException extends ActiveMQException {
+
Review comment:
Probably should be an extension of the existing
ActiveMQSessionCreationException so any old code with an explicit catch clause
still gets caught
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 295246)
Time Spent: 0.5h (was: 20m)
> throw ActiveMQResourceLimitException if session/queue limit is reached
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-2442
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2442
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: yangwei
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Now ActiveMQSessionCreationException is thrown when session/queue limit is
> reached. ActiveMQSessionCreationException is used to indicate server is
> starting. It would cause session recreation retries all the time. Session
> creation should fail fast when limit is reached so client can try to connect
> other brokers in cluster.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
