[
https://issues.apache.org/jira/browse/ARTEMIS-2442?focusedWorklogId=297024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297024
]
ASF GitHub Bot logged work on ARTEMIS-2442:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/19 06:07
Start Date: 19/Aug/19 06:07
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2785:
ARTEMIS-2442 throw ActiveMQResourceLimitException if session/queue limit is
reached
URL: https://github.com/apache/activemq-artemis/pull/2785#discussion_r315049421
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQExceptionType.java
##########
@@ -261,6 +261,12 @@ public ActiveMQException createException(String msg) {
public ActiveMQException createException(String msg) {
return new ActiveMQReplicationTimeooutException(msg);
}
+ },
+ RESOURCE_LIMIT_REACHED(221) {
Review comment:
Point here just because theyre catching the base doesnt mean everyone is
By changing the exception should try make it a extended of the current so
people dont get any shock changes in their error handling logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 297024)
Time Spent: 1.5h (was: 1h 20m)
> throw ActiveMQResourceLimitException if session/queue limit is reached
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-2442
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2442
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: yangwei
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Now ActiveMQSessionCreationException is thrown when session/queue limit is
> reached. ActiveMQSessionCreationException is used to indicate server is
> starting. It would cause session recreation retries all the time. Session
> creation should fail fast when limit is reached so client can try to connect
> other brokers in cluster.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
