[
https://issues.apache.org/jira/browse/ARTEMIS-2442?focusedWorklogId=295973&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295973
]
ASF GitHub Bot logged work on ARTEMIS-2442:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Aug/19 02:41
Start Date: 16/Aug/19 02:41
Worklog Time Spent: 10m
Work Description: wy96f commented on pull request #2785: ARTEMIS-2442
throw ActiveMQResourceLimitException if session/queue limit is reached
URL: https://github.com/apache/activemq-artemis/pull/2785#discussion_r314566358
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/ActiveMQExceptionType.java
##########
@@ -261,6 +261,12 @@ public ActiveMQException createException(String msg) {
public ActiveMQException createException(String msg) {
return new ActiveMQReplicationTimeooutException(msg);
}
+ },
+ RESOURCE_LIMIT_REACHED(221) {
Review comment:
For older client that don't understand, "ActiveMQException"(type code is
GENERIC_EXCEPTION) would be decoded and thrown. There are two places where
ActiveMQExceptionType.SESSION_CREATION_REJECTED is judged, one is
ActiveMQSessionContext::recreateSession(), the other is BridgeImpl::connect().
For both of them, the logic is same in the case of GENERIC_EXCEPTION(old
client) and RESOURCE_LIMIT_EXCEEDED(new client).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 295973)
Time Spent: 40m (was: 0.5h)
> throw ActiveMQResourceLimitException if session/queue limit is reached
> ----------------------------------------------------------------------
>
> Key: ARTEMIS-2442
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2442
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: yangwei
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Now ActiveMQSessionCreationException is thrown when session/queue limit is
> reached. ActiveMQSessionCreationException is used to indicate server is
> starting. It would cause session recreation retries all the time. Session
> creation should fail fast when limit is reached so client can try to connect
> other brokers in cluster.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
