[ https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408598&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408598 ]
ASF GitHub Bot logged work on ARTEMIS-2676: ------------------------------------------- Author: ASF GitHub Bot Created on: 24/Mar/20 08:49 Start Date: 24/Mar/20 08:49 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 PageCursorProviderImpl::cleanup can save decoding pages without large messages URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-603100401 I've run the CI tests and this change seems to work fine yay Perf-wise and on stability is a nice improvement over the original version, although not perfect: ideally we should skip reading the Page at all, but now we save a lot of CPU time and heap space by saving useless message decoding :+1: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 408598) Time Spent: 1h 10m (was: 1h) > PageCursorProviderImpl::cleanup can save decoding pages without large messages > ------------------------------------------------------------------------------ > > Key: ARTEMIS-2676 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2676 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker > Affects Versions: 2.11.0 > Reporter: Francesco Nigro > Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > PageCurosrProviderImpl::cleanup is calling > PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not > present in the PageCache), just to trigger large messages delete. > The decoding phase could be skipped and possibly the page read as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)