[ 
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=413564&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413564
 ]

ASF GitHub Bot logged work on ARTEMIS-2676:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Mar/20 22:23
            Start Date: 31/Mar/20 22:23
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on issue #3044: ARTEMIS-2676 
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-606912942
 
 
   Look at the AMQPLargeMessagePersister. you would need to check that 
record.... but please you would need to have the proper operations on the OO 
model.... not much about OO here, but about organizing the code in such way we 
can find the operation when we need it.
   
   
   I think it's valid to check if the record is for Paging, but you would have 
to do it in an organized way. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 413564)
    Time Spent: 2h 50m  (was: 2h 40m)

> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> ------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2676
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.11.0
>            Reporter: Francesco Nigro
>            Priority: Major
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling 
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not 
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to