[ 
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=408632&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408632
 ]

ASF GitHub Bot logged work on ARTEMIS-2676:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Mar/20 10:01
            Start Date: 24/Mar/20 10:01
    Worklog Time Spent: 10m 
      Work Description: franz1981 commented on issue #3044: ARTEMIS-2676 
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-603143665
 
 
   @clebertsuconic 
   I need some help to understand the impact of this change I've made on 
`Page::delete`:
   
![image](https://user-images.githubusercontent.com/13125299/77412327-06971580-6dbe-11ea-8639-d9f4501ad75e.png):
   
   - before: was calling `Message::usageDown` on each message
   - now: it's calling `Message::usageDown` only for large messages
   
   I see that ddd8ed440226fa9099f894fa0dd5c1e03614b7da has introduced 
`usageDown` to be triggered on ANY message, was it correct? 
   
![image](https://user-images.githubusercontent.com/13125299/77412812-b5d3ec80-6dbe-11ea-86f9-c92790a54a5c.png)
   It's ok if I'm calling it just for large messages?
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 408632)
    Time Spent: 1h 20m  (was: 1h 10m)

> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> ------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2676
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.11.0
>            Reporter: Francesco Nigro
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling 
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not 
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to