[
https://issues.apache.org/jira/browse/ARTEMIS-2682?focusedWorklogId=411571&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411571
]
ASF GitHub Bot logged work on ARTEMIS-2682:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/20 00:43
Start Date: 28/Mar/20 00:43
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on issue #3043:
ARTEMIS-2682: OpenWireMessageConverter refactoring
URL: https://github.com/apache/activemq-artemis/pull/3043#issuecomment-605369255
its still not compiling.....even after your latest commit, i really am
thinking is this PR worth it, if its only a refactor, but not benefit, just
risk oi what else is broken, if it doesnt even compile?!?!
The biggest thing for me in this space if someone was to refactor is to
actually introduce Native OpenWireMessage support, so for openwire to openwire
we dont convert. Then it be worth the risk/effort.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 411571)
Time Spent: 0.5h (was: 20m)
> OpenWireMessageConverter refactoring
> ------------------------------------
>
> Key: ARTEMIS-2682
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2682
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: OpenWire
> Affects Versions: 2.12.0
> Reporter: Federico Valeri
> Priority: Minor
> Labels: openwire, refactoring
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I'm proposing the {{OpenWireMessageConverter}} refactoring to have a similar
> layout as the {{AMQPConverter}}. The latter has two dedicated classes for
> inbound and outbound messages with a singleton entry point for the converter.
> This change is basically doing the same without semantics change and also
> adding a unit test for the converter. I'm also eliminating some duplicated
> code, but the bulk of the code remains untouched.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
