[
https://issues.apache.org/jira/browse/ARTEMIS-2682?focusedWorklogId=411946&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411946
]
ASF GitHub Bot logged work on ARTEMIS-2682:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/20 16:49
Start Date: 29/Mar/20 16:49
Worklog Time Spent: 10m
Work Description: fvaleri commented on issue #3043: ARTEMIS-2682:
OpenWireMessageConverter refactoring
URL: https://github.com/apache/activemq-artemis/pull/3043#issuecomment-605665524
Same reason as before, I hope the fix is pushed now and I also added an
initial set of unit tests.
I think that a feature like native OpenWire message support would inevitably
include some refactoring. If you are not sensible to better maintainability,
then you could also take this as a first step in that direction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 411946)
Time Spent: 50m (was: 40m)
> OpenWireMessageConverter refactoring
> ------------------------------------
>
> Key: ARTEMIS-2682
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2682
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: OpenWire
> Affects Versions: 2.12.0
> Reporter: Federico Valeri
> Priority: Minor
> Labels: openwire, refactoring
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I'm proposing the {{OpenWireMessageConverter}} refactoring to have a similar
> layout as the {{AMQPConverter}}. The latter has two dedicated classes for
> inbound and outbound messages with a singleton entry point for the converter.
> This change is basically doing the same without semantics change and also
> adding a unit test for the converter. I'm also eliminating some duplicated
> code, but the bulk of the code remains untouched.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
