[
https://issues.apache.org/jira/browse/ARTEMIS-3074?focusedWorklogId=543017&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543017
]
ASF GitHub Bot logged work on ARTEMIS-3074:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/21 19:14
Start Date: 27/Jan/21 19:14
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #3412:
URL: https://github.com/apache/activemq-artemis/pull/3412#issuecomment-768513610
The PR looks good and I'm ready to merge, but I had one additional
question...
As I was reviewing the PR I noticed that while the bridge configuration
references a connector there isn't actually any way to add a new connector via
the management API which means every new bridge will have to use a connector
which *already exists*. This is a gap in functionality that has been there for
a long time, but I just now noticed it. Is this gap going to impact your
use-case? If not, I'll go ahead and merge and then send a PR later for a new
management method for adding a connector.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 543017)
Time Spent: 3h 40m (was: 3.5h)
> Add ActiveMQServerControl#createBridge() method variant which accepts the
> callTimeout attribute
> -----------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-3074
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3074
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.16.0
> Reporter: Tomas Hofman
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Currently there are four variants of the
> {{ActiveMQServerControl#createBridge()}} method, none of which accepts the
> {{callTimeout}} attribute of the core bridge.
> The {{callTimeout}} attribute sets a call timeout for blocking calls to the
> server. Typically a bridge works in a non-blocking manner, but in some cases
> customers use configurations where calls do block.
> It would still be possible to set call timeout without this change using
> lower level API ({{ActiveMQServer#deployBridge()}}), but it would require
> duplicating some code which is already there in {{ActiveMQServerControl}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
