[
https://issues.apache.org/jira/browse/ARTEMIS-3074?focusedWorklogId=539430&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-539430
]
ASF GitHub Bot logged work on ARTEMIS-3074:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/21 02:03
Start Date: 22/Jan/21 02:03
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #3412:
URL: https://github.com/apache/activemq-artemis/pull/3412#issuecomment-765062691
Aside from my inline comments I've got a few others...
- Please deprecate all the other `createBridge` management methods.
- Add another test like
`org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlTest#testCreateAndDestroyBridge`
using the new method.
> ...it would allow also us to create method
`ActiveMQServerControl#createBridge(BridgeConfiguration)` :), which may be nice
type safe addition to the JSON string version.
Management methods should only take simple types so they can be invoked from
JMX tools as well as HTTP via Jolokia. The only time a complex object (e.g.
`BridgeConfiguration`) would be used is if the invoking client was in the same
JVM but in that case they could use the embedded broker's configuration API
directly and won't need the management method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 539430)
Time Spent: 2h 10m (was: 2h)
> Add ActiveMQServerControl#createBridge() method variant which accepts the
> callTimeout attribute
> -----------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-3074
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3074
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.16.0
> Reporter: Tomas Hofman
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently there are four variants of the
> {{ActiveMQServerControl#createBridge()}} method, none of which accepts the
> {{callTimeout}} attribute of the core bridge.
> The {{callTimeout}} attribute sets a call timeout for blocking calls to the
> server. Typically a bridge works in a non-blocking manner, but in some cases
> customers use configurations where calls do block.
> It would still be possible to set call timeout without this change using
> lower level API ({{ActiveMQServer#deployBridge()}}), but it would require
> duplicating some code which is already there in {{ActiveMQServerControl}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
