[
https://issues.apache.org/jira/browse/ARTEMIS-3074?focusedWorklogId=541591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-541591
]
ASF GitHub Bot logged work on ARTEMIS-3074:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/21 04:01
Start Date: 26/Jan/21 04:01
Worklog Time Spent: 10m
Work Description: TomasHofman commented on pull request #3412:
URL: https://github.com/apache/activemq-artemis/pull/3412#issuecomment-767069329
Sorry for the long delays, I'm in the middle of a release...
I realized there are further complications regarding default values. E.g.
user and password fields default to `"ACTIVEMQ.CLUSTER.ADMIN.USER"` and
`"CHANGE ME!!"` and we need to be able to set them to `null`, which means null
values have to be deserialized. I chose following behavior:
* All non-null values are always serialized to JSON, even if they are
default (this could be changed to serialize only if value is non-default, but
to me that seems it would be confusing),
* if JSON string doesn't contain a field, during deserialization it will be
instantiated with its' default value,
* if JSON string contains a field with `null`, it will be instantiated to
null, regardless of it's default value (unless it's a primitive type field
which would fail).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 541591)
Time Spent: 3h 10m (was: 3h)
> Add ActiveMQServerControl#createBridge() method variant which accepts the
> callTimeout attribute
> -----------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-3074
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3074
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: API
> Affects Versions: 2.16.0
> Reporter: Tomas Hofman
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Currently there are four variants of the
> {{ActiveMQServerControl#createBridge()}} method, none of which accepts the
> {{callTimeout}} attribute of the core bridge.
> The {{callTimeout}} attribute sets a call timeout for blocking calls to the
> server. Typically a bridge works in a non-blocking manner, but in some cases
> customers use configurations where calls do block.
> It would still be possible to set call timeout without this change using
> lower level API ({{ActiveMQServer#deployBridge()}}), but it would require
> duplicating some code which is already there in {{ActiveMQServerControl}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
