[
https://issues.apache.org/jira/browse/ARTEMIS-3137?focusedWorklogId=559449&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-559449
]
ASF GitHub Bot logged work on ARTEMIS-3137:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/21 16:29
Start Date: 01/Mar/21 16:29
Worklog Time Spent: 10m
Work Description: jbertram commented on a change in pull request #3466:
URL: https://github.com/apache/activemq-artemis/pull/3466#discussion_r584862620
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSXPathSelectorTest.java
##########
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.amqp;
Review comment:
This test extends
`org.apache.activemq.artemis.tests.integration.amqp.JMSClientTestSupport` which
in turn extends
`org.apache.activemq.artemis.tests.integration.amqp.AmqpClientTestSupport`
which in turn extends
`org.apache.activemq.artemis.tests.integration.amqp.AmqpTestSupport`. Therefore
either all these would need to be visible to wherever I move this test or they
would need to be refactored and their multi-protocol functionality extracted
into something more generic. I'd like to avoid pulling that thread in this PR,
although I think it would be a great idea to address multi-protocol JMS tests
generally in another PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 559449)
Time Spent: 5h (was: 4h 50m)
> Support XPath filters
> ---------------------
>
> Key: ARTEMIS-3137
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3137
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
