[
https://issues.apache.org/jira/browse/ARTEMIS-3137?focusedWorklogId=560128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560128
]
ASF GitHub Bot logged work on ARTEMIS-3137:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/21 20:46
Start Date: 02/Mar/21 20:46
Worklog Time Spent: 10m
Work Description: jbertram commented on a change in pull request #3466:
URL: https://github.com/apache/activemq-artemis/pull/3466#discussion_r585896398
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSXPathSelectorTest.java
##########
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.amqp;
Review comment:
> ...I dont think the parents need moved at all for the very small thing
I am suggesting of putting the class in the package most appropriate for it.
I guess I misunderstood. I thought you wanted the test to move away from the
`org.apache.activemq.artemis.tests.integration.amqp` package since it wasn't
specifically related to AMQP. Given that, it didn't (and still doesn't) make
sense to me for a non-AMQP-specific test to have a parent that is
AMQP-specific. That's why I concluded that the generic multi-protocol
functionality would have to be refactored out of the AMQP-specific test parent
classes.
> Not every parent needs to be in the same package, they often arent.
Agreed. However, to have a generic test with a more specific parent doesn't
make a lot of sense to me.
> Everything in the multiprotocol package is already parented by [different]
classes outwith that package.
Which package are you referring to specifically here?
> Looking at moving e.g. the existing selector test class now...
Can you clarify which package this test would move to? Is it
logically/heirarchically "above" or "lateral" to
`org.apache.activemq.artemis.tests.integration.amqp`?
To be frank, this is starting to feel a bit like bike shedding to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 560128)
Time Spent: 6.5h (was: 6h 20m)
> Support XPath filters
> ---------------------
>
> Key: ARTEMIS-3137
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3137
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
